From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pdm-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: applied: [PATCH datacenter-manager/proxmox v2 0/7] auto-install: add support for VLAN and bond configurations
Date: Sat, 7 Nov 2026 23:10:53 +0100 [thread overview]
Message-ID: <179408929293.3054669.10671586917541607291.b4-ty@b4> (raw)
In-Reply-To: <20261106131419.822904-1-c.heiss@proxmox.com>
On Fri, 06 Nov 2026 14:14:11 +0100, Christoph Heiss wrote:
> Prerequisites: [0] for the installer site.
>
> This adds a new advanced section in the "Network" tab of the prepared
> answer add/edit dialog.
>
> With this, the user can the VLAN tag and/or bonding for newly installed
> system.
> Bond member selection uses udev filters, to provide a way to dynamically
> select network interfaces for target systems.
>
> [...]
Applied, thanks!
I folded a few changes into your patches see trailer for details, the relevant
ones:
- patches 1 to 3 are squashed into one commit, as they only build
together, which also initializes the new fields in the add wizard.
- backend: use the bond types from proxmox-network-types, make
bond-enabled optional, so that API clients not sending it keep
working, take a VLAN tag only with a static network configuration, as
with DHCP the installer uses the VLAN of its installation environment,
require a member filter for bonding and check the options before
saving.
- UI: keep the serialized names for the filesystem types. Their Display
implementation returns the installer's labels, which the form cannot
parse back, so saving an answer with XFS, ZFS or BTRFS selected fell
back to ext4.
- UI: disable the network device filter with bonding, as the installer
ignores it then, require the member filter and a used hash policy,
show 802.3ad as LACP, and say why the VLAN tag is disabled with DHCP.
On top, as separate follow up commits:
- only send answers the installer can use: an installer reporting an
older answer fetch schema than the answer needs gets an error naming
the required version, and the installation gets a new status, so that
the list shows which answer matched but was not sent.
- generate answer tokens only after all checks passed, so that a
refused request no longer leaves an unused enabled token behind.
- describe the bond and VLAN options in the docs.
- bump proxmox-installer-types to 0.3.1 and proxmox-network-types to
1.2.1.
In proxmox, I added tests for the names of the bond modes and hash
policies, and installer-types now shows the MAC addresses in its bond
errors in lowercase, like the installers and `ip link` do.
[datacenter-manager] applied to git/proxmox-datacenter-manager.git (master)
[1/5] config: auto-install: add new options for configuring vlan and bond
commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e
[2/5] api-types: auto-installer: add new options for configuring vlan and bond
commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e
[3/5] api: auto-installer: wire up new vlan and bond network options
commit: 75e67f844b21f924b9e2c9ec5eb4f70ae1fd580e
[4/5] ui: auto-installer: use .to_string() instead of manual serde variant
commit: e1dae047d10c40e5660a6aa0b1676a33cbd45c02
[5/5] ui: auto-installer: add vlan and bond config as advanced options
commit: 9f02124119b6f807d42e15bbcb447224ca007443
[proxmox] applied to git/proxmox.git (master)
[1/2] installer-types: derive Display for RebootMode and FilterMatch
commit: 50ca2db5d5f17bc07859ba666415c7ad6a9eb4a8
[2/2] network-types: derive Display and FromStr for network bond types
commit: f7d3035fa42374d419bc56c4be941ea4f2570b7c
prev parent reply other threads:[~2026-11-07 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 13:14 [PATCH datacenter-manager/proxmox v2 0/7] auto-install: add support for VLAN and bond configurations Christoph Heiss
2026-11-06 13:14 ` [PATCH proxmox v2 1/7] installer-types: derive Display for RebootMode and FilterMatch Christoph Heiss
2026-11-06 13:14 ` [PATCH proxmox v2 2/7] network-types: derive Display and FromStr for network bond types Christoph Heiss
2026-11-06 13:14 ` [PATCH datacenter-manager v2 3/7] config: auto-install: add new options for configuring vlan and bond Christoph Heiss
2026-11-06 13:14 ` [PATCH datacenter-manager v2 4/7] api-types: auto-installer: " Christoph Heiss
2026-11-06 13:14 ` [PATCH datacenter-manager v2 5/7] api: auto-installer: wire up new vlan and bond network options Christoph Heiss
2026-11-06 13:14 ` [PATCH datacenter-manager v2 6/7] ui: auto-installer: use .to_string() instead of manual serde variant Christoph Heiss
2026-11-06 13:14 ` [PATCH datacenter-manager v2 7/7] ui: auto-installer: add vlan and bond config as advanced options Christoph Heiss
2026-11-07 22:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179408929293.3054669.10671586917541607291.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.