From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A08DB1FF0EC for ; Sat, 07 Nov 2026 19:10:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9734C2143A; Sat, 07 Nov 2026 19:10:26 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH qemu-server v7 0/2] hotplug: improve and fix cleanup/error handling Date: Sat, 7 Nov 2026 19:09:22 +0100 Message-ID: <179407495998.1712155.17271494632806962802.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261105082524.428152-1-d.csapak@proxmox.com> References: <20261105082524.428152-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794074969461 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.279 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5N347JD4FMW6KFSK6LIHEJ6DNAJV536R X-Message-ID-Hash: 5N347JD4FMW6KFSK6LIHEJ6DNAJV536R X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 05 Nov 2026 09:22:13 +0100, Dominik Csapak wrote: > This replaces my earlier v4 9/9 patch[0] > > It uses a different approach now by unifying the cleanup and removal of > disks and their controllers. > > changes from v6: > * call print_drivedevice_full before adding the SCSI controller, so a > volume rejected by the storage layer (e.g. a vanished storage) does > not cause a controller plug/unplug cycle, and add a test for it > * add a test for a failed disk hotplug on a shared SCSI controller, > which must keep the controller for the remaining disks > > [...] Applied, thanks! [1/2] hotplug: factor out cleanup of disk devices https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=b300bb7df2a2ff007bfa8cb2e5766942d035a638 [2/2] hotplug: clean up disk devices/objects if adding them failed https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=afbc929c23ba002a648f4a9d322595fb7cea63a7