all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, "Michael Köppl" <m.koeppl@proxmox.com>
Subject: applied: [PATCH http-server 1/1] apiserver: send TLS close notify at the end of streamed responses
Date: Thu,  5 Nov 2026 18:50:42 +0100	[thread overview]
Message-ID: <179389936161.3822907.14665617337133974164.b4-ty@b4> (raw)
In-Reply-To: <20261103155223.1960754-1-m.koeppl@proxmox.com>

On Tue, 03 Nov 2026 16:52:23 +0100, Michael Köppl wrote:
> A streamed response (e.g. for the single file restore download), has no
> Content-Length nor chunked encoding, so the client can only tell where
> the body ends by the connection being closed. The response accounced
> 'Connection: Keep-Alive' and, at the end of the stream, push_shutdown()
> shut down the socket directly, bypassing the TLS layer. The client then
> receives a TCP FIN without a TLS close notify [0].
> 
> [...]

Applied, with s/apiserver/response/ for the subject, thanks!

[1/1] apiserver: send TLS close notify at the end of streamed responses
      commit: d4d74a6de412f9a946089cbfccec62b519557c73

Though in local tests the patch alone did not yet make the close notify a
reliable end-of-download signal, so I applied three commits before it:

- c2d96d0: with output still queued at the end of a stream, the close
  notify could only get queued and the following shutdown lost it. curl
  thus still failed with error 56 after receiving a complete download.

- 7ba3802: a disconnect aborting a stream could send a close notify too,
  making a truncated download look complete. That goes back to 07e56cc,
  but clients can only rely on the close notify if it's not sent then.

- 124c146: on a reused connection, a pipelined request could replace the
  source of an active stream, so the client received the other response
  as the body. With push_shutdown() gone, that could now end with a
  clean close notify too.




      parent reply	other threads:[~2026-11-05 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 15:52 [PATCH http-server 1/1] apiserver: send TLS close notify at the end of streamed responses Michael Köppl
2026-11-03 16:19 ` Michael Köppl
2026-11-05 17:50 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179389936161.3822907.14665617337133974164.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal