From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B8BC81FF0DF for ; Thu, 05 Nov 2026 15:12:47 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3C5A72158F; Thu, 05 Nov 2026 15:12:44 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com, Michal Fox Subject: applied: [PATCH guest-common] fix #7408: guest helpers: activate storage before checking hookscript Date: Thu, 5 Nov 2026 15:12:35 +0100 Message-ID: <179388795361.1125112.17880777919815135888.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260929134852.2660793-1-me@dualfroz.com> References: <20260929134852.2660793-1-me@dualfroz.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793887960776 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.578 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XKHUJOAPLWYMZK2PM4GT4AVDVFCZVHQQ X-Message-ID-Hash: XKHUJOAPLWYMZK2PM4GT4AVDVFCZVHQQ X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 29 Sep 2026 15:48:52 +0200, Michal Fox wrote: > The hookscript is looked up on its storage without activating it first. > If the snippets live on a network storage like CIFS or NFS that is not > mounted yet, for example when a guest is started on boot, the check > fails with "script ... does not exist" and the guest does not start, > even though the storage would be mounted on its first regular use. > > Activate the storage of the hookscript volume before checking the file, > as is done for any other volume used by a guest. > > [...] Applied, thanks! [1/1] fix #7408: guest helpers: activate storage before checking hookscript commit: b091195887bfb9ac547021293f5b091cc2582d9e Best regards, -- Fabian Grünbichler