From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 094681FF0DF for ; Thu, 05 Nov 2026 14:32:26 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 580A3215CA; Thu, 05 Nov 2026 14:32:24 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com, Aaron Carson Subject: applied: [PATCH proxmox-acme v2] acme: fix USER_AGENT variable interpolation in curl calls Date: Thu, 5 Nov 2026 14:30:59 +0100 Message-ID: <179388543088.1046105.4460775233116602698.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260812120711.3626458-1-aaron@aaroncarson.co.uk> References: <20260812120711.3626458-1-aaron@aaroncarson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793885540622 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.605 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6XRSJGAEA3SAJT3DJS2ZJFQTROBAQDFG X-Message-ID-Hash: 6XRSJGAEA3SAJT3DJS2ZJFQTROBAQDFG X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Aug 2026 12:02:28 +0000, Aaron Carson wrote: > The variable was not interpolated, so ACME requests were sent with > the literal string USER_AGENT as the user agent instead of the > configured value. > > Applied, thanks! [1/1] acme: fix USER_AGENT variable interpolation in curl calls commit: ca6249a55d6ae61f703e98eb36e8f49acff27084 Best regards, -- Fabian Grünbichler