From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Michal Fox <me@dualfroz.com>
Subject: applied: [PATCH proxmox-acme] fix #7155: proxmox-acme: support upper-hex mode of _url_encode
Date: Thu, 5 Nov 2026 14:31:00 +0100 [thread overview]
Message-ID: <179388543087.1046105.13888509223557962367.b4-ty@proxmox.com> (raw)
In-Reply-To: <20261004125925.7-1-me@dualfroz.com>
On Sun, 04 Oct 2026 12:59:25 +0000, Michal Fox wrote:
> The _url_encode function of acme.sh takes an optional 'upper-hex'
> argument, which makes it output the percent-encoded characters with
> upper-case hex digits. Our copy of the function in proxmox-acme lacks
> it and always outputs lower-case hex.
>
> The Aliyun DNS plugin of the bundled acme.sh version uses this argument
> for the signature of its API requests, as the Aliyun API requires
> upper-case hex there. So the signature never matched, and adding the
> TXT record always failed with "SignatureDoesNotMatch".
>
> [...]
Applied, thanks!
[1/1] fix #7155: proxmox-acme: support upper-hex mode of _url_encode
commit: 8281c38197c1fc8b18f92b73760beb8a4de3936b
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-11-05 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 12:59 [PATCH proxmox-acme] fix #7155: proxmox-acme: support upper-hex mode of _url_encode Michal Fox
2026-11-05 13:31 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179388543087.1046105.13888509223557962367.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=me@dualfroz.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.