From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A10171FF0DF for ; Thu, 05 Nov 2026 12:09:18 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6F7D2214CB; Thu, 05 Nov 2026 12:09:18 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied-series: [PATCH proxmox-backup 0/2] fix potential panic on key decryption Date: Thu, 5 Nov 2026 12:06:57 +0100 Message-ID: <179387681542.804336.14251894349082233631.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261021164112.464267-1-c.ebner@proxmox.com> References: <20261021164112.464267-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793876955090 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.650 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7QRR22B62Z4EEY7WGK6DN2FOR7QDZNO4 X-Message-ID-Hash: 7QRR22B62Z4EEY7WGK6DN2FOR7QDZNO4 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 21 Oct 2026 18:41:10 +0200, Christian Ebner wrote: > This patches address a useless key length check on a fixed size array > slice as well as an insufficient length check when decrypting the key > data via KeyConfig::decrypt(). The latter will result in a panic when > source and target length mismatch and is now handled as error. > > Christian Ebner (2): > pbs-key-config: drop useless length check enforce by type > fix: pbs-key-config: do not panic on short decrypted keys > > [...] Applied with a small follow-up, thanks! Sent https://lore.proxmox.com/pbs-devel/20261105110750.805444-1-f.gruenbichler@proxmox.com as further follow-up that might warrant more discussion. [1/2] pbs-key-config: drop useless length check enforce by type commit: a23876b82f2c00e1454a3ac6d452594a9f5fa6da [2/2] fix: pbs-key-config: do not panic on short decrypted keys commit: 6cd68788c200f00b585a399d6f00a389121fc191 Best regards, -- Fabian Grünbichler