From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 693EB1FF0AA for ; Tue, 03 Nov 2026 09:51:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2D37F217DE; Tue, 03 Nov 2026 09:51:07 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] GC: fail on abnormal system time drifted between phase 1 and 2 Date: Tue, 3 Nov 2026 09:50:58 +0100 Message-ID: <179369585196.173029.1315894671488856463.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261030113113.5877-1-c.ebner@proxmox.com> References: <20261030113113.5877-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793695865068 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.431 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3HMYIHOA3C2HNBZECVS3NIHZ4D5FYAB5 X-Message-ID-Hash: 3HMYIHOA3C2HNBZECVS3NIHZ4D5FYAB5 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 30 Oct 2026 12:31:13 +0100, Christian Ebner wrote: > The garbage collection cutoff time for chunks being considered as no > longer in-use and therefore removed is calculated at the start of > phase 1, taking into account the system time. Chunks access timestamp > is then updated using utimensat() calls with the current system time. > > If the system time changed into the past between phase 1 and phase 2, > e.g. due to unexpected manual intervention or NTP time update, in-use > chunks might be incorrectly assumed as no longer referenced. > > [...] Applied, thanks! [1/1] GC: fail on abnormal system time drifted between phase 1 and 2 commit: 3f86c85137bff040642cf839b87b0e8fcf254df3 Best regards, -- Fabian Grünbichler