From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 273751FF0AA for ; Tue, 03 Nov 2026 01:01:35 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 31C9821772; Tue, 03 Nov 2026 01:01:31 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Elias Huhsovitz Subject: applied: [PATCH proxmox-perl-rs v2 0/3] makefile: reduce ambiguity for targets: all/install/upload Date: Tue, 3 Nov 2026 01:01:21 +0100 Message-ID: <179366407991.2376650.10770167397646741326.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261030132533.150795-1-e.huhsovitz@proxmox.com> References: <20261030132533.150795-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793664086953 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.345 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VFAH3MO3X5OUCWUYGN7XL7D7OTFP2Q7I X-Message-ID-Hash: VFAH3MO3X5OUCWUYGN7XL7D7OTFP2Q7I X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 30 Oct 2026 14:25:30 +0100, Elias Huhsovitz wrote: > I encounted some minor inconsistencies in the Makefile: > * make install only installs from release dir (Even though 'make all' > generates a debug build per default) > * File Fixup.pm is used inside a target but not specified as a > prerequisite. > * unsued variable for upload target. > > [...] Applied, thanks! [1/3] makefile: use TARGET_DIR variable for install target commit: 36b4ef9c65e5d8dcc385d625ae9c3909d0fd31f3 [2/3] makefile: add Fixup.pm as prerequisite for $(BUILDDIR) commit: 9ca4005750a48b87c35b5b1ba595e59e1aebd95e [3/3] makefile: use UPLOAD_DIST variable commit: f5dc49f50dbcd27aa3b7b8b8a266caa7162ed900