From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Subject: applied: [PATCH pve-firewall v3] api: aliases: make cidr optional on update and preserve comment
Date: Tue, 3 Nov 2026 00:22:47 +0100 [thread overview]
Message-ID: <179366176537.2144882.9208850266644918848.b4-ty@b4> (raw)
In-Reply-To: <20261015054534.25978-1-a.bied-charreton@proxmox.com>
On Thu, 15 Oct 2026 07:45:34 +0200, Arthur Bied-Charreton wrote:
> Updating an alias required passing its CIDR, and dropped the existing
> comment unless it was passed again. Clients therefore had to fetch the
> alias first just to send back the currently configured CIDR and comment.
>
> Make 'cidr' optional in PUT .../firewall/aliases/{name} and keep the
> existing CIDR and comment if none is passed. Passing an empty comment
> still clears it.
>
> [...]
Applied, thanks!
[1/1] api: aliases: make cidr optional on update and preserve comment
commit: 1bba92a1505a3ca9c69b853998e1f020cff1c8da
prev parent reply other threads:[~2026-11-02 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 5:45 [PATCH pve-firewall v3] api: aliases: make cidr optional on update and preserve comment Arthur Bied-Charreton
2026-11-02 23:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179366176537.2144882.9208850266644918848.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.