From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 01D971FF0B3
	for <inbox@lore.proxmox.com>; Wed, 28 Oct 2026 18:28:22 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 86D152151E;
	Wed, 28 Oct 2026 18:28:08 +0100 (CET)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	David Riley <d.riley@proxmox.com>
Subject: applied: [PATCH common/manager v3 0/4] fix #8006: acme:
 lifetime-based certificate renewal threshold
Date: Wed, 28 Oct 2026 18:27:52 +0100
Message-ID: <179320847229.1870597.16235995289031511910.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261021095229.50842-1-d.riley@proxmox.com>
References: <20261021095229.50842-1-d.riley@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793208482881
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.470 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: NZTRSWHVX2GINHADMBOP5CK2SGR5AI6W
X-Message-ID-Hash: NZTRSWHVX2GINHADMBOP5CK2SGR5AI6W
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Wed, 21 Oct 2026 11:52:25 +0200, David Riley wrote:
> Thanks Michael K. for taking a look at v2.
> 
> Differences from v2:
> * Split both pve-common and pve-manager patches into two commits each
>   (4 commits total) as suggested by Michael K.
> 
> Differences from v1:
> * Refactor: Reduce certificate reads by combining the read of
>   notBefore and notAfter.
> * Add: Warning users of certificates with lifetime <= 0
> * Add: minimum lead time of 3 days
> * Update 'force' parameter description in API schema
> * Add: dynamic lead time calculation to bin/pveupdate
> 
> [...]

Applied, thanks!

[pve-common] applied to git/pve-common.git (master)
[1/2] certificate: add helper to extract validity period
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=ee8a63829f93fc2e5ff9b330dc2bd097ac273b68
[2/2] certificate: add helper for lifetime-based ACME renewal lead time
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=07097f6f24a78d1cbc8839b0b9ae3b46c8198e52

[pve-manager] applied to pve-manager.git (master)
[1/2] fix #8006: api: acme: use lifetime-based certificate renewal lead time
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=4ef7f6a03a7f4cc3787adf94340ae33235640e5d
[2/2] fix #8006: pveupdate: use lifetime-based renewal lead time
      https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=5fba1afba8cd2c16724a4b6d74602b01a50e28d9