From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 44C3B1FF0B3 for ; Wed, 28 Oct 2026 17:16:26 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 30376213C5; Wed, 28 Oct 2026 17:16:23 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Thomas Ellmenreich Subject: applied: [PATCH qemu-server v3 0/3] refactor of volume_id classification Date: Wed, 28 Oct 2026 17:16:09 +0100 Message-ID: <179320416728.1677009.4745153252256756207.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260812121327.145140-1-t.ellmenreich@proxmox.com> References: <20260812121327.145140-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793204177871 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.480 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Z2OAX4YVGZW3EPIHBWL6FHPZ34AZ66GL X-Message-ID-Hash: Z2OAX4YVGZW3EPIHBWL6FHPZ34AZ66GL X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Aug 2026 14:13:24 +0200, Thomas Ellmenreich wrote: > Refactor of volume_id classification > ==================================== > > While developing this: [0] patch series, I refactored all the checks for > disk files as absolute paths into their own subroutine. The original series > was then dropped in favour of a quicker fix: [1]. This series revives the > refactor without the fix and, unlike the original series creates a new > classify_drive_file subroutine, as @Fiona Ebener mentioned here: [2]. > > [...] Applied, thanks! [1/3] move verify_volume_id_or_* format registrations into Drive submodule https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=d25b17648448311d040ea03060594d252dd95965 [2/3] add new classify_drive_file utility https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=08d0bf270e90048fa63b1d8ee36cdef62438665d [3/3] remove unnecessary undef checks https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=fa8aee77fc3103950eeac81ab6ba01ad2569538c