From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 5D7521FF0B3 for ; Wed, 28 Oct 2026 17:16:53 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 62C6321654; Wed, 28 Oct 2026 17:16:24 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Thomas Ellmenreich Subject: applied: [PATCH qemu-server 0/3] drive: account for differing TPM sizes Date: Wed, 28 Oct 2026 17:16:08 +0100 Message-ID: <179320416726.1677009.13238742729492248976.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261027101723.144576-1-t.ellmenreich@proxmox.com> References: <20261027101723.144576-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793204177815 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.477 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W2JWAYQWGXHTFN7SRMAGKKWLPBK535S7 X-Message-ID-Hash: W2JWAYQWGXHTFN7SRMAGKKWLPBK535S7 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 27 Oct 2026 11:17:20 +0100, Thomas Ellmenreich wrote: > Our current systems to handle TPM drives always assume that the disks have a > fixed 4MiB size that cannot be changed even if that may not be the case. In > situations where the granularity of the backing storage exceeds the 4MiB, an > allocation of a TPM drive will be at least as big as the granularity of said > backing storage. > > To solve this mismatch in a very simple way, the default size is retained for > allocation. Only after the allocation do we check the actual size of the > created TPM disk and update the configuration accordingly. A minimum size of > 4MiB is always applied to situations where that may not be the case. > > [...] Applied, thanks! [1/3] drive: update TPM size as max of current and minimum size https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=314e1338b3f83dc4a76f8458e95560b1743ae82e [2/3] api: create disks: update TPM size on creation https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=73d06ea0a54452df3634359f6d9f08ed76c754a3 [3/3] clone disk: read actual size when cloning TPM drive https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=10a812e9df4b77ea3c91d10b705212adf6265efa