all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH proxmox-i18n v3 00/12] Makefile simplifications and improvements
Date: Tue, 13 Oct 2026 12:49:08 +0200	[thread overview]
Message-ID: <179188828728.3746353.2769337013152384195.b4-ty@b4> (raw)
In-Reply-To: <20260727095957.223209-1-m.sandoval@proxmox.com>

On Mon, 27 Jul 2026 11:59:43 +0200, Maximiliano Sandoval wrote:
> The main difference in behavior is that we add --previous to the msgmerge
> command used to update the PO files. This can add some extra information to
> translations, which can make it easier to determine whether the previous
> translation is still valid or what kind of modifications it needs.
> 
> See individual commits and their notes.
> 
> [...]

Applied, thanks!

With some changes folded in, see added trailers in commit, but in essence:
- 01: dropped the msgmerge call instead, as msgfmt never read its output and
  merging would not change the catalog anyway; 02 lost its catalog-%.mo hunk
  accordingly
- 08: added the missing meson link
- 09: switched to diffing LINGUAS against make's sorted PO file list, which
  is locale independent and names the offending entries
- 10: switched to sorting in the C locale, matching check-linguas
- 11, 12: dropped .PHONY for the pattern targets, .PHONY does not take
  patterns
- some commit message rewording and rewrapping

Also added two fixes:
- make: yew catalogs: fail on msgmerge errors (416e84a)
- make: init-%.po: pass language code as locale to msginit (0d3e5e5),
  it passed messages.pot, so new PO files failed 'make check'

[01/12] make: catalog-%.mo: explicitly set template file
        commit: 0f434c5de01b85e3c4b8853deeb1317d0e1b6daf
[02/12] make: simplify msgmerge commands
        commit: 6e83f0c26f5d8683d914c65175d0b75ea047f964
[03/12] make: clean: remove *.mo files
        commit: ad57c55dbe2b45dfefcd6c33461f3b269e545bb4
[04/12] make: use long options for msgmerge and msginit
        commit: 1f1da3194c9e351e0e6c2a8b9ee1a8136d810153
[05/12] make: do_update: add --update for msgmerge
        commit: 3b3e95a3f84ca93c76cbbfcbc856377abbef0688
[06/12] make: do_update: add --previous flag to msgmerge
        commit: 18d4857a154ab020e09b51e8d5d45449e787e0dd
[07/12] gitignore: remove proxmox-datacenter-manager.pot
        commit: 8ab58721347f07b9187629c34c6ab43702e747b1
[08/12] make: move linguas to a file
        commit: e6258e3f90bf8438890e145de627b2a06b893de0
[09/12] make: add check-linguas target
        commit: 47e09ac2a0348f9c3cc7128ecc37a3015b2175d6
[10/12] make: init-%.po: add language to linguas
        commit: a3991f890095363ae215176a2eca87cfecbfa561
[11/12] make: add targets to update specific PO files
        commit: 738ab96e7ed2135c721f33b9a65aa19dcab7db56
[12/12] make: rename check-% target to check-%.po
        commit: 57958aad2ee4fb03bc632b7e9da2e679360d1759




      parent reply	other threads:[~2026-10-14  9:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  9:59 [PATCH proxmox-i18n v3 00/12] Makefile simplifications and improvements Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 01/12] make: catalog-%.mo: explicitly set template file Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 02/12] make: simplify msgmerge commands Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 03/12] make: clean: remove *.mo files Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 04/12] make: use long options for msgmerge and msginit Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 05/12] make: do_update: add --update for msgmerge Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 06/12] make: do_update: add --previous flag to msgmerge Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 07/12] gitignore: remove proxmox-datacenter-manager.pot Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 08/12] make: move linguas to a file Maximiliano Sandoval
2026-07-29  7:15   ` Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 09/12] make: add check-linguas target Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 10/12] make: init-%.po: add language to linguas Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 11/12] make: add targets to update specific PO files Maximiliano Sandoval
2026-07-27  9:59 ` [PATCH proxmox-i18n v3 12/12] make: rename check-% target to check-%.po Maximiliano Sandoval
2026-10-13 10:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179188828728.3746353.2769337013152384195.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal