all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Michal Fox <me@dualfroz.com>
Subject: applied: [PATCH storage] fix #6969: plugin: keep content directory when freeing its last file
Date: Fri,  9 Oct 2026 02:46:26 +0200	[thread overview]
Message-ID: <179150678419.2472338.2377678236832983349.b4-ty@b4> (raw)
In-Reply-To: <20260926093257.7-1-me@dualfroz.com>

On Sat, 26 Sep 2026 09:32:57 +0000, Michal Fox wrote:
> After removing a volume, free_image tries to remove the parent
> directory, so that no empty per-guest directories are left behind once
> all images of a guest are gone. This was done unconditionally, so
> deleting the last ISO, container template, snippet or import file also
> removed the shared content directory like 'snippets' or 'template/iso'.
> 
> The directory gets re-created shortly after by pvestatd, but as
> root:root with default permissions, losing any ownership or mode that
> the admin set up, for example to allow a non-root user to upload
> snippets.
> 
> [...]

Applied, thanks!

[1/1] fix #6969: plugin: keep content directory when freeing its last file
      https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=c10faa69723a824ed52837ad8d185c20bc472020




      parent reply	other threads:[~2026-10-09  0:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-26  9:32 [PATCH storage] fix #6969: plugin: keep content directory when freeing its last file Michal Fox
2026-09-28 13:37 ` Max R. Carrara
2026-10-09  0:46 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=179150678419.2472338.2377678236832983349.b4-ty@b4 \
    --to=t.lamprecht@proxmox.com \
    --cc=me@dualfroz.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal