From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, Michal Fox <me@dualfroz.com>
Subject: applied: [PATCH manager] fix #5608: ui: resource mappings: validate the name like the API does
Date: Wed, 30 Sep 2026 12:27:53 +0200 [thread overview]
Message-ID: <179076404143.1629239.10192032693270079310.b4-ty@b4> (raw)
In-Reply-To: <20260929141313.2873638-1-me@dualfroz.com>
On Tue, 29 Sep 2026 16:13:13 +0200, Michal Fox wrote:
> The API only accepts resource mapping IDs in the 'pve-configid' format,
> but the name field of the PCI, USB and directory mapping windows takes
> any value. A name like 'gpu@node1' is thus only rejected after
> submitting, with a generic "invalid configuration ID" error that does
> not tell which characters are allowed.
>
> Use the existing 'ConfigId' vtype, so the field is marked invalid right
> away and its tooltip lists the allowed characters.
>
> [...]
Applied, thanks!
[1/1] fix #5608: ui: resource mappings: validate the name like the API does
commit: 55c76c27465287eccef01d16f26ff1d6fe37569a
prev parent reply other threads:[~2026-09-30 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 14:13 [PATCH manager] fix #5608: ui: resource mappings: validate the name like the API does Michal Fox
2026-09-30 10:27 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179076404143.1629239.10192032693270079310.b4-ty@b4 \
--to=d.csapak@proxmox.com \
--cc=me@dualfroz.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.