From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 708AF1FF0AB for ; Wed, 23 Sep 2026 21:15:53 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 005B82166F; Wed, 23 Sep 2026 21:15:40 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Hannes Laimer Subject: applied: [PATCH proxmox-firewall] nftables: move protocol match rendering into the lib Date: Wed, 23 Sep 2026 21:15:28 +0200 Message-ID: <179019092317.3587707.3336155015345173254.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260827131524.1411472-1-h.laimer@proxmox.com> References: <20260827131524.1411472-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790190936129 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.717 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PFW3HNF62GQUUR6KKMGD3JQ2IVQYMXA2 X-Message-ID-Hash: PFW3HNF62GQUUR6KKMGD3JQ2IVQYMXA2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 27 Aug 2026 15:15:24 +0200, Hannes Laimer wrote: > The statements selecting a transport protocol, its ports or an ICMP type > and code were generated in proxmox-firewall, although which statements > select a protocol is nftables knowledge and does not depend on the > firewall config. Move the rendering into proxmox-nftables, working on > plain expressions, and add an entry point taking the firewall's protocol > type to the config extension. The firewall keeps its IP family pinning > on top. > > [...] Applied, thanks! [1/1] nftables: move protocol match rendering into the lib commit: 9840e166b7109e3aed00293e326d88f19b4bd391