From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 337D01FF0AB
	for <inbox@lore.proxmox.com>; Wed, 23 Sep 2026 18:57:57 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id A679D215CA;
	Wed, 23 Sep 2026 18:57:56 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pbs-devel@lists.proxmox.com,
	=?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
Subject: applied: [PATCH proxmox] fix #6267: rest-server: fix task log
 rotation race
Date: Wed, 23 Sep 2026 18:57:39 +0200
Message-ID: <179018250731.2852909.18142160847730209200.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260923114403.856979-1-f.gruenbichler@proxmox.com>
References: <20260923114403.856979-1-f.gruenbichler@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790182671923
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.758 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 34R2H4BPMGBPQKQJQY2YGHYDGZXJWCUM
X-Message-ID-Hash: 34R2H4BPMGBPQKQJQY2YGHYDGZXJWCUM
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On Wed, 23 Sep 2026 13:43:12 +0200, Fabian Grünbichler wrote:
> if the task log archive files get rotated, the base `archive` file is renamed
> to `archive.1`. until it is recreated, iterating over the archive files returns
> no files.
> 
> on systems with a lot of task activity, task rotation could be effectively
> broken:
> - every logrotate task rotated the task archive files
> - the subsequent handling of the archive files to find out which task logs to
>   clean found no task archive files at all - only rotated copies existed
> 
> [...]

Applied, thanks!

[1/1] fix #6267: rest-server: fix task log rotation race
      commit: c999d605ddffb457640ac301b3a74fddc398aefa