From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 967801FF0AA for ; Tue, 22 Sep 2026 22:34:44 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 448DF21466; Tue, 22 Sep 2026 22:34:44 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH] fix #7823: tape: don't set up a data-in transfer for non-data commands Date: Tue, 22 Sep 2026 22:34:34 +0200 Message-ID: <179010927039.4032217.6669723958191565211.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260817123128.2813924-1-d.csapak@proxmox.com> References: <20260817123128.2813924-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790109280822 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.765 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PBVQSMPXNRMF2VYIX2EFJJ6OLZSBNHUG X-Message-ID-Hash: PBVQSMPXNRMF2VYIX2EFJJ6OLZSBNHUG X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 17 Aug 2026 14:29:52 +0200, Dominik Csapak wrote: > do_command() required a transfer buffer of at least 16 bytes, so all > commands without a data transfer phase (REWIND, SPACE, LOCATE, MOVE > MEDIUM, ...) allocated a dummy buffer just to satisfy that check. Since > create_scsi_pt_obj() hands any non-empty buffer to > set_scsi_pt_data_in(), those commands announced a data-in transfer that > they never fulfill. > > [...] Applied, thanks! [1/1] fix #7823: tape: don't set up a data-in transfer for non-data commands commit: 308ad7fa5442051adc44c56fe1d4a1084bdcaae0