From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, "Michael Köppl" <m.koeppl@proxmox.com>
Subject: applied: [PATCH qemu-server 1/1] fix #8030: snapshot: avoid orphaned vmstate volume on failure
Date: Tue, 22 Sep 2026 15:26:14 +0200 [thread overview]
Message-ID: <179008357127.384092.4717454414015502114.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260914140547.615346-1-m.koeppl@proxmox.com>
On Mon, 14 Sep 2026 16:05:47 +0200, Michael Köppl wrote:
> The state volume was allocated before the running instance was queried
> for its machine type, CPU argument and network MTUs. Those queries can
> fail (e.g. the 'query-machines' QMP command, which can run into a
> timeout while QEMU's is busy [0]).
>
> The helper is called from __snapshot_prepare() before write_config(), so
> the config never records the snapshot, snapshot_create() dies before it
> gets to its cleanup path. Such a failure leaves behind the just
> allocated volume.
>
> [...]
Applied, thanks!
[1/1] fix #8030: snapshot: avoid orphaned vmstate volume on failure
commit: 1db755c9bb3233d92770b8d9dcd8f3792380daec
prev parent reply other threads:[~2026-09-22 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 14:05 [PATCH qemu-server 1/1] fix #8030: snapshot: avoid orphaned vmstate volume on failure Michael Köppl
2026-09-22 8:14 ` Jakob Klocker
2026-09-22 8:44 ` Elias Huhsovitz
2026-09-22 13:26 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179008357127.384092.4717454414015502114.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.