From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Jakob Klocker <j.klocker@proxmox.com>
Subject: applied: [PATCH storage v3 0/2] fix #7598: qemu-img: increase timeout for image resize
Date: Fri, 18 Sep 2026 10:29:57 +0200 [thread overview]
Message-ID: <178972019162.20962.13034324928353555188.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260811073740.100398-1-j.klocker@proxmox.com>
On Tue, 11 Aug 2026 09:37:38 +0200, Jakob Klocker wrote:
> Image resizing currently has a timeout of 10 seconds, which can fail
> on slow disks and leave the VM in a state where the disk is updated,
> but the VM config isn't.
>
> Since there is no deterministic way to check, with less overhead, if
> this is the case, increasing the timeout is the most pragmatic
> solution. The resize is only called in a worker context anyway,
> therefore this patch series mirrors the ZFS timeout: it increases
> the timeout in a worker context to 1 hour; as a fallback for a
> non-worker context the timeout stays 10 seconds.
>
> [...]
Applied, thanks! In the second patch, I made two small changes:
* style: avoid combining ternary conditional operator and post-if
* wrap doc comment to avoid line longer than 100 characters
[1/2] qemu-img: drop redundant timeout argument at resize call
commit: 1b930a64a67ba21b7e3f4d3cfb578f240c71b661
[2/2] fix #7598: qemu-img: increase timeout for image resizing in worker context
commit: e27a8036f5dc9d2d09e427b055264d97725566d7
prev parent reply other threads:[~2026-09-18 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 7:37 [PATCH storage v3 0/2] fix #7598: qemu-img: increase timeout for image resize Jakob Klocker
2026-08-11 7:37 ` [PATCH pve-storage v3 1/2] qemu-img: drop redundant timeout argument at resize call Jakob Klocker
2026-08-13 9:04 ` Elias Huhsovitz
2026-08-11 7:37 ` [PATCH pve-storage v3 2/2] fix #7598: qemu-img: increase timeout for image resizing in worker context Jakob Klocker
2026-08-13 9:06 ` Elias Huhsovitz
2026-09-18 8:29 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178972019162.20962.13034324928353555188.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=j.klocker@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.