From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1538C1FF0AB for ; Wed, 09 Sep 2026 14:32:21 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4F34A2162F; Wed, 09 Sep 2026 14:32:12 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH proxmox-backup 24/28] ui: add retention timespan form and use it for sync job edit window From: Robert Obkircher To: Christian Ebner In-Reply-To: <20260813171002.809441-25-c.ebner@proxmox.com> References: <20260813171002.809441-1-c.ebner@proxmox.com> <20260813171002.809441-25-c.ebner@proxmox.com> Date: Wed, 09 Sep 2026 14:32:04 +0200 Message-Id: <178895712462.166875.18212098489797391672.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788957117991 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.502 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) PROLO_LEO1 0.1 Meta Catches all Leo drug variations so far RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YBTNVEVWASGYJXLNFMZK4SCYGA6L4OJW X-Message-ID-Hash: YBTNVEVWASGYJXLNFMZK4SCYGA6L4OJW X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > Based on the calender event form, the retention timespan form > provides some useful template values for snapshot retention to > be set on sync jobs. > > Signed-off-by: Christian Ebner > > diff --git a/www/Makefile b/www/Makefile > index 568836455..e14a17507 100644 > --- a/www/Makefile > +++ b/www/Makefile > @@ -56,6 +56,7 @@ JSSRC= \ > form/GroupFilter.js \ > form/VerifyOutdatedAfter.js \ > form/EncryptionKeySelector.js \ > + form/RetentionTimespan.js \ > data/RunningTasksStore.js \ > button/TaskButton.js \ > panel/PrunePanel.js \ > diff --git a/www/form/RetentionTimespan.js b/www/form/RetentionTimespan.js > new file mode 100644 > index 000000000..9a84c59a2 > --- /dev/null > +++ b/www/form/RetentionTimespan.js > @@ -0,0 +1,21 @@ > +Ext.define('PBS.data.RetentionTimespanTemplates', { > + extend: 'Ext.data.Store', > + alias: 'store.retentionTimespanTemplates', > + > + field: ['value', 'text'], > + data: [ > + { value: '1 day', text: Ext.String.format(gettext('Retain for {0} day'), 1) }, > + { value: '4 weeks', text: Ext.String.format(gettext('Retain for {0} weeks'), 4) }, > + { value: '1 month', text: Ext.String.format(gettext('Retain for {0} month'), 1) }, > + { value: '1 year', text: Ext.String.format(gettext('Retain for {0} year'), 1) }, nit: The "Retain for " prefix sounds a bit off to me, when selecting the maximum retention timespan. -- Robert Obkircher