From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: applied: [PATCH qemu-server] qemu: viommu: small variable code cleanup
Date: Tue, 1 Sep 2026 14:46:54 +0200 [thread overview]
Message-ID: <178826676890.166612.74485394150663090.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260831112543.2552200-1-d.csapak@proxmox.com>
On Mon, 31 Aug 2026 13:25:37 +0200, Dominik Csapak wrote:
> Reusing a variable the way done here reads not very nice and is easily
> missable and possibly misunderstood. Instead use a dedicated variable
> for the aw-bits additional and directly use that when pushing the
> devices to the list.
>
> No functionality change intended.
>
> [...]
Applied, thanks! I changed the commit title to be a bit clearer and
avoid the superfluous 'qemu' prefix.
[1/1] code cleanup: cfg2cmd: viommu: avoid unintuitive variable reuse
commit: 9cba97b4f2d9244ea40ddac5130bc4d147bb1dc3
prev parent reply other threads:[~2026-09-01 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 11:25 [PATCH qemu-server] qemu: viommu: small variable code cleanup Dominik Csapak
2026-09-01 12:46 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178826676890.166612.74485394150663090.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.