From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EA62F1FF0C1 for ; Wed, 26 Aug 2026 16:20:12 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 552BC21347; Wed, 26 Aug 2026 16:20:12 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH container] fix: #7148: check CT protection before reassigning volume Date: Wed, 26 Aug 2026 16:16:35 +0200 Message-ID: <178775379009.210123.1931139643106353439.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260601115240.36497-1-j.klocker@proxmox.com> References: <20260601115240.36497-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787753999815 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.781 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6RF5OYAU3PR5JZW6XCXIHIGRGZITYO6C X-Message-ID-Hash: 6RF5OYAU3PR5JZW6XCXIHIGRGZITYO6C X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 01 Jun 2026 13:52:40 +0200, Jakob Klocker wrote: > When reassigning a volume, check the destination config before > removing the volume from the source config. Applied, thanks! Ran make tidy, extended the commit message a bit and avoided the misleading "volume '$target_mpkey'" in the error message, which wrongly uses the target mp id, while making it fully explicit that the assignment to the target is what fails because of the protection mode. [1/1] fix: #7148: check CT protection before reassigning volume commit: c05243e426f69abc06a5768cafdbca3934f6caa4