From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 9885B1FF0E6 for ; Sun, 23 Aug 2026 15:06:14 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A49CB213A9; Sun, 23 Aug 2026 15:06:11 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Christian Ebner Subject: Re: [PATCH v4 pve-qemu qemu-server 0/3] bypass host page cache for restore on zvol Date: Sun, 23 Aug 2026 15:04:33 +0200 Message-ID: <178749026798.3745671.6636752437746243191.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260820131049.374072-1-c.ebner@proxmox.com> References: <20260820131049.374072-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787490325751 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.973 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3S7VA37TOKABMUZYYFELRYMW6CY5SRBZ X-Message-ID-Hash: 3S7VA37TOKABMUZYYFELRYMW6CY5SRBZ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 20 Aug 2026 15:10:46 +0200, Christian Ebner wrote: > This patch series skips writing to the host page cache for restores > to zvols, with the intention to avoid potential I/O delay issues for > other ZFS-backed VMs during page writeback on certain setups, as > reported in enterprise support and reproduced internally. > > This patch series adds an optional no-cache parameter for pbs-restore > command invocation, setting the BDRV_O_NOCACHE flag for the block > device being restored to and sets `cache=none` for vma restores. > > [...] Applied, with some minor fix-ups squashed in for qemu-server, thanks! [pve-qemu] applied to git/pve-qemu (master) [1/1] pbs-restore: add optional no-cache flag to bypass host page cache commit: 21690c02e4e7a472b9d69caee77a941652c1dbdb [qemu-server] applied to qemu-server.git (master) [1/2] pbs-restore: set 'no-cache' on block devices backed by zfspool https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=c6b3237333b07794fb0c929b7fd02449af622452 [2/2] vma restore: skip page cache on block devices backed by zfspool https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=2abb892c4421922aaa27817eacc38c513b95e7aa