From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 020681FF0AA for ; Fri, 21 Aug 2026 16:00:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9EE41215A8; Fri, 21 Aug 2026 16:00:36 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH datacenter-manager 06/20] pdm-config: subscriptions: rename trait methods to read/write/lock From: Robert Obkircher To: Lukas Wagner In-Reply-To: <20260817125727.454039-7-l.wagner@proxmox.com> References: <20260817125727.454039-1-l.wagner@proxmox.com> <20260817125727.454039-7-l.wagner@proxmox.com> Date: Fri, 21 Aug 2026 16:00:31 +0200 Message-Id: <178732083104.243770.4631361288224973083.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787320806653 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.660 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5LVYNN6SJ3TRX25UORA5X3MMOKAG3OZV X-Message-ID-Hash: 5LVYNN6SJ3TRX25UORA5X3MMOKAG3OZV X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pdm-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > PdmApplication bundles the client factory, remote config, subscription > key config, and product config behind a single cloneable handle. This > replaces the growing set of independent global statics with one object > that can be assembled differently for production, the fake-remote > feature, and integration tests. Bundling them is convenient, but the components could additionally be registered individually, to allow for application independent methods. e.g. State could work in PBS as well. That might be a bad example though, becasue api_user and priv_user are used all over the place and should maybe remain static [1]. I wonder if conditionally compiling to static variables for release builds and tokio::task_local in tests would work there. [1] https://lore.proxmox.com/pbs-devel/20260723090815.206114-1-c.ebner@proxmox.com/ -- Robert Obkircher