Re: [PATCH proxmox 03/20] api-macro: support shared state extraction type

[Robert Obkircher <r.obkircher@proxmox.com>]

> The State<T> newtype wraps values that come from the registry, which
> allows telling them apart from regular API parameters. The API macro
> recognizes them in API handler signatures and looks them up in the
> shared state registry of the RpcEnvironment, instead of deserializing
> them from the request parameters. That way a handler declares its
> dependencies on application state in its signature and does not have to
> access the environment by hand.

Another way of telling them appart would be to use an attribute. It's
slightly more verbose by itself, but it would make it easier to pass
the type by value:

e.g.
fn a(#[state] foo: Foo) { f(foo) }
fn b(foo: State<Foo>) { f(*foo) }

Or simply removing the wrapper from the proc macro output could work as
well, but that might be confusing.

The wrapper is totally fine though, I just wanted to mention this for
completeness.

-- 
Robert Obkircher <r.obkircher@proxmox.com>