From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Kaiyang Wu <wukaiyang2003@gmail.com>
Subject: applied: [PATCH qemu-server v3] query-machine-capabilities: limit AuthenticAMD and GenuineIntel checks to x86-64
Date: Thu, 6 Aug 2026 16:45:24 +0200 [thread overview]
Message-ID: <178602752228.188771.17538228327089000968.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260730014713.64822-2-wukaiyang@loongfans.cn>
On Thu, 30 Jul 2026 09:47:05 +0800, Kaiyang Wu wrote:
> Intel TDX and AMD SEV are both x86-64-only extensions [0] [1]. The current
> method of checking results in compilation errors on "unknown" vendors,
> where the current placeholder string length ("Unknown") mismatches the
> lengths of both "AuthenticAMD" and "GenuineIntel":
>
> error: ‘strncmp’ of strings of length 7 and 12 and bound of 12
> evaluates to nonzero [-Werror=string-compare]
>
> [...]
Applied, thanks! I put the check for ret < 0 inside the conditional
compilation to avoid having a stand-alone duplicate when compiled on
neither x86_64 nor aarch64.
[1/1] query-machine-capabilities: limit AuthenticAMD and GenuineIntel checks to x86-64
commit: c3cf6795a4e48ca4dd02d922f9227070c13f2b59
prev parent reply other threads:[~2026-08-06 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 1:47 [PATCH qemu-server v3] query-machine-capabilities: limit AuthenticAMD and GenuineIntel checks to x86-64 Kaiyang Wu
2026-08-06 14:45 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178602752228.188771.17538228327089000968.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=wukaiyang2003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.