From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Subject: applied: [PATCH qemu-server v2] fix #7705: blockdev: detach backing chain on disk move/hot-unplug
Date: Thu, 6 Aug 2026 16:23:08 +0200 [thread overview]
Message-ID: <178602618491.178016.4045535869763004231.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260617121330.347174-1-a.bied-charreton@proxmox.com>
On Wed, 17 Jun 2026 14:12:13 +0200, Arthur Bied-Charreton wrote:
> When snapshots-as-volume-chains is enabled, moving or hot-unplugging a
> disk that holds snapshots does not detach the snapshot volumes.
> `Blockdev::detach` is called in both paths and only follows the `file`
> child, so the snapshot nodes are left behind. Since they were added
> explicitly via blockdev-add, they are also not GCed by QEMU and, as a
> result, keep their source volumes open.
>
> [...]
Applied, thanks! I reformulated the code comment, mainly to replace
'chain node' with 'node in a chain' and because the original line was
101 characters. And a small nit: could've been one patch introducing
the new option and a second one actually making use of it, but it's
also fine like this.
[1/1] fix #7705: blockdev: detach backing chain on disk move/hot-unplug
commit: cfc229a5ea4d246adce9374ab6db8e0ada06920f
prev parent reply other threads:[~2026-08-06 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 12:12 [PATCH qemu-server v2] fix #7705: blockdev: detach backing chain on disk move/hot-unplug Arthur Bied-Charreton
2026-06-18 7:25 ` Jakob Klocker
2026-08-06 14:23 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178602618491.178016.4045535869763004231.b4-ty@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.