Re: [PATCH perlmod v2 4/5] macro: function: move signature inputs handling into helper struct

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Fri, 24 Jul 2026 16:49:06 +0200, Max R. Carrara <m.carrara@proxmox.com> wrote:
> diff --git a/perlmod-macro/src/function.rs b/perlmod-macro/src/function.rs
> index 3ca7bd0..f5415c5 100644
> --- a/perlmod-macro/src/function.rs
> +++ b/perlmod-macro/src/function.rs
> @@ -210,6 +210,171 @@ fn deserialized_argument_code(
> [ ... skip 44 lines ... ]
> +            let arg_attr = ArgumentAttr::new_from_fn_arg(arg)?;
> +
> +            let arg_type: &syn::Type = arg_attr.pat_type.ty.as_ref();
> +
> +            let arg_name = {
> +                let pattern: &syn::Pat = arg_attr.pat_type.pat.as_ref();

This binding is unnecessary - let's drop the enclosing block and
indentation and match directly…

> +                match pattern {
> +                    syn::Pat::Ident(ident) => {
> +                        if ident.by_ref.is_some() {
> +                            bail!(ident => "xsub does not support by-ref parameters");
> +                        }
> +                        if ident.subpat.is_some() {
> +                            bail!(ident => "xsub does not support sub-patterns on parameters");
> +                        }
> +                        &ident.ident
> +                    }
> +                    _ => bail!(pattern => "xsub does not support this kind of parameter"),

… ↑ with `s/_/pattern/` here.

> @@ -451,36 +527,48 @@ pub fn handle_function(
> [ ... skip 30 lines ... ]
> -        proto.push(';');
> -        for _ in 0..trailing_options {
> -            proto.push('$');
> +
> +    match (trailing_options, trailing_type) {
> +        (1.., ty) => {

Not too happy about this - the `if` previously was sufficient, and the
`match` now doesn't do any matching on `trailing_type` - it just rebinds
it to `ty`, so just more indentation for no gain?

--