From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 64D501FF0E5 for ; Wed, 29 Jul 2026 15:03:40 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 31B3A2132E; Wed, 29 Jul 2026 15:03:40 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied-series: [PATCH proxmox-backup v3 0/5] restrict previous manifest reuse checks for push sync jobs Date: Wed, 29 Jul 2026 15:00:58 +0200 Message-ID: <178533005540.644993.6938528626229983453.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260729090737.135385-1-c.ebner@proxmox.com> References: <20260729090737.135385-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785330188525 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: POAIIQ4XBSKCEQ2RUWCO2WTFJL43PMXN X-Message-ID-Hash: POAIIQ4XBSKCEQ2RUWCO2WTFJL43PMXN X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 29 Jul 2026 11:07:32 +0200, Christian Ebner wrote: > Restrict and rework the checks for reuse of previous snapshots > manifest's for push sync jobs, in particular with key and signature > mismatches for sync jobs with active encryption key. > In particular, only allow reuse of the previous manifest if either > the previous manifest is not encrypted, and the push sync will also > not encrypt or the previous manifest is encrypted with the matching > active encryption key configured for the sync job, the manifest's > signature being verified with that key. > > [...] Applied, thanks! [1/5] datastore: data blob: refactor crypt mode method commit: b00fe46ee37479805bebff0eb3e2b131ca88c9b1 [2/5] datastore: data blob: refactor decoding method commit: 71ab92143a2e98a2bd9f4756f1e860348f1a72af [3/5] client: backup writer: pass no crypt config to manifest blob decoder commit: 0f60e71d79ff02e0e65618609ea02981f4ca520d [4/5] client: allow skipping signature check on previous manifest fetching commit: b80847b554be38f7a9bcae9bf09e14dfb64afa22 [5/5] sync: push: gracefully handle previous manifest signature mismatches commit: bb3a5fdfcfde5324a5b15a34e72138273df69c7e Best regards, -- Fabian Grünbichler