all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: applied: [PATCH storage] fix #7811: storage: lvm: reject allocation on format and volume name mismatch
Date: Fri, 24 Jul 2026 11:35:18 +0200	[thread overview]
Message-ID: <178488571614.355016.6933965562231473577.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260716103243.61836-1-e.huhsovitz@proxmox.com>


On Thu, 16 Jul 2026 12:32:43 +0200, Elias Huhsovitz wrote:
> When users allocate a new volume via the API and request a specific
> format (like 'qcow2'), but provide a volume name without the
> corresponding extension (like 'vm-100-disk-0'), the generic API
> validation misses the inconsistency. This occurs because standard LVM
> raw volumes do not use file extensions.
> 
> The LVMPlugin ignored this mismatch. It created a raw
> logical volume and logged a misleading "formatting as qcow2" message.
> This resulted in a confusing state where the storage lists the volume
> as 'raw', but the underlying block device contains a 'qcow2' image.
> 
> [...]

Applied with `make tidy` folded in, thanks!

If you think there are other paths that would benefit from this helper being
called, feel free to send additional patches!

[1/1] fix #7811: storage: lvm: reject allocation on format and volume name mismatch
      commit: 05032c5903313e2133754c62d6d35a56551b476b

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>




      parent reply	other threads:[~2026-07-24  9:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 10:32 [PATCH storage] fix #7811: storage: lvm: reject allocation on format and volume name mismatch Elias Huhsovitz
2026-07-21 12:50 ` Max R. Carrara
2026-07-24  9:35 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178488571614.355016.6933965562231473577.b4-ty@proxmox.com \
    --to=f.gruenbichler@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal