From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 467541FF0E0 for ; Thu, 23 Jul 2026 19:47:15 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AEB692148A; Thu, 23 Jul 2026 19:47:14 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Subject: applied: [PATCH storage] zfspool: export: fix regression with printing progress output Date: Thu, 23 Jul 2026 19:47:01 +0200 Message-ID: <178482881863.1777338.3823031547185343376.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260723085132.29326-1-f.ebner@proxmox.com> References: <20260723085132.29326-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784828799199 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.210 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: U324FHRODYLWOELYRD3ME6KYA54CJ63A X-Message-ID-Hash: U324FHRODYLWOELYRD3ME6KYA54CJ63A X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 23 Jul 2026 10:50:37 +0200, Fiona Ebner wrote: > The progress from zfs send is printed to stderr, but the lines are > passed from run_command() to errfunc() without a trailing newline in > and so they would not show up in the task log right away, even with > the following call to flush. Use chomp() for future-proofing (e.g. if > there were an $errmsg, run_command() would call errfunc() with a > newline) and attach an explicit newline for each line passed to the > errfunc() to fix the issue. > > [...] Applied, thanks! [1/1] zfspool: export: fix regression with printing progress output https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=22cea6404b13fded68afee146b9e60383ae8eb2d