From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id E3A1F1FF0E0
	for <inbox@lore.proxmox.com>; Thu, 23 Jul 2026 16:17:34 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id B49B321489;
	Thu, 23 Jul 2026 16:17:34 +0200 (CEST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH proxmox v3 1/3] rest-server: add request logfilter by
 method and path in h2 service
From: Robert Obkircher <r.obkircher@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <20260721114806.505047-2-c.ebner@proxmox.com>
References: <20260721114806.505047-1-c.ebner@proxmox.com>
 <20260721114806.505047-2-c.ebner@proxmox.com>
Date: Thu, 23 Jul 2026 16:17:29 +0200
Message-Id: <178481624960.207559.16327170625450950852.b4-review@b4>
X-Mailer: b4 0.16-dev
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1784816222170
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.166 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: SXSX655ODABBXVYGJGXSTAZINFGBGM2N
X-Message-ID-Hash: SXSX655ODABBXVYGJGXSTAZINFGBGM2N
X-MailFrom: r.obkircher@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pbs-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

> Allows to optionally filter incoming requests to be excluded from the
> task log. The filter method is provided on instantiation and passes
> the request method and path.
> 
> A first usecase for this is to filter out HTTP level heartbeat
> requests send by the client's backup reader implementation in order
> to avoid log flodding.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>
> diff --git a/proxmox-rest-server/src/h2service.rs b/proxmox-rest-server/src/h2service.rs
> index b5edc703..be3797dc 100644
> --- a/proxmox-rest-server/src/h2service.rs
> +++ b/proxmox-rest-server/src/h2service.rs
> @@ -27,15 +27,23 @@ pub struct H2Service<E> {
>      rpcenv: E,
>      worker: Arc<WorkerTask>,
>      debug: bool,
> +    log_filter: Option<fn(&hyper::Method, &str) -> bool>,
If we expect more complex, stateful filters in the future then 
`Option<Arc<dyn Fn>>` would be better.
>  }
>  
>  impl<E: RpcEnvironment + Clone> H2Service<E> {
> -    pub fn new(rpcenv: E, worker: Arc<WorkerTask>, router: &'static Router, debug: bool) -> Self {
> +    pub fn new(
> +        rpcenv: E,
> +        worker: Arc<WorkerTask>,
> +        router: &'static Router,
> +        debug: bool,
> +        log_filter: Option<fn(&hyper::Method, &str) -> bool>,
> +    ) -> Self {
>          Self {
>              rpcenv,
>              worker,
>              router,
>              debug,
> +            log_filter,
>          }
>      }
>  
> @@ -55,7 +63,13 @@ impl<E: RpcEnvironment + Clone> H2Service<E> {
>              Err(err) => return future::err(http_err!(BAD_REQUEST, "{}", err)).boxed(),
>          };
>  
> -        self.debug(format!("{method} {path}"));
> +        if !self
> +            .log_filter
> +            .map(|filter| filter(&method, &path))
> +            .unwrap_or_default()
This confused me initially, because filters are usually associated
with predicates that return true for the elements that should be
kept.

-- 
Robert Obkircher <r.obkircher@proxmox.com>