From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C25811FF0E0 for ; Thu, 23 Jul 2026 14:35:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6AF4021459; Thu, 23 Jul 2026 14:35:39 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH proxmox-backup v5 07/15] pbs-config: drop backup_group helper, use users gid instead From: Robert Obkircher To: Christian Ebner In-Reply-To: <20260723090815.206114-8-c.ebner@proxmox.com> References: <20260723090815.206114-1-c.ebner@proxmox.com> <20260723090815.206114-8-c.ebner@proxmox.com> Date: Thu, 23 Jul 2026 14:35:34 +0200 Message-Id: <178481013413.196809.13240394483313511356.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784810106770 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.173 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SYTJDLP52UZH7NERCAAOTVXCEPNMN2ZU X-Message-ID-Hash: SYTJDLP52UZH7NERCAAOTVXCEPNMN2ZU X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 23 Jul 2026 11:08:07 +0200, Christian Ebner wrote: > Use the gid as reported for the backup user, which matches the > `backup` group anyways. By this it is possible to use the user > provided via proxmox-product-config::get_api_user() for chunk store > operations instead, avoiding expensive user/group lookups. Reviewed-by: Robert Obkircher -- Robert Obkircher