From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: applied: [PATCH pve-firewall 1/1] fix #7818: disallow line feeds in firewall comments
Date: Thu, 16 Jul 2026 10:58:32 +0200 [thread overview]
Message-ID: <178419231061.201965.12652046655276203125.b4-ty@proxmox.com> (raw)
In-Reply-To: <20260715093432.34437-1-s.hanreich@proxmox.com>
On Wed, 15 Jul 2026 11:34:30 +0200, Stefan Hanreich wrote:
> They do not get sanitized and interpreted literally, allowing for
> authenticated users to inject additional lines into the firewall
> configuration files.
>
>
Applied, thanks!
Went with this v1 instead of the v2, since it fixes the issue and the proposed
changes in v2 should be discussed, and if acked, applied wholesale not just to
this individual field.
[1/1] fix #7818: disallow line feeds in firewall comments
commit: 97a07715161cea9fd403f473d3e19a6dc857d018
Best regards,
--
Fabian Grünbichler <f.gruenbichler@proxmox.com>
prev parent reply other threads:[~2026-07-16 8:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:34 [PATCH pve-firewall 1/1] fix #7818: disallow line feeds in firewall comments Stefan Hanreich
2026-07-15 9:48 ` Stoiko Ivanov
2026-07-15 10:11 ` Stefan Hanreich
2026-07-15 10:11 ` superseded: " Stefan Hanreich
2026-07-16 8:58 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178419231061.201965.12652046655276203125.b4-ty@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.