From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 2AC4D1FF142
	for <inbox@lore.proxmox.com>; Fri, 03 Jul 2026 15:36:19 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 18314213A2;
	Fri, 03 Jul 2026 15:36:18 +0200 (CEST)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Daniel Kral <d.kral@proxmox.com>
Subject: applied: [RFC PATCH guest-common] tunnel: treat reader_stderr as
 optional parameter in read_tunnel
Date: Fri,  3 Jul 2026 15:35:20 +0200
Message-ID: <178308571625.160753.8329800893982790898.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260630084332.32566-1-d.kral@proxmox.com>
References: <20260630084332.32566-1-d.kral@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783085736024
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.006 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: EXDO75LYJVXICN3XBJIAN2FBS5QOQ6OF
X-Message-ID-Hash: EXDO75LYJVXICN3XBJIAN2FBS5QOQ6OF
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 30 Jun 2026 10:43:32 +0200, Daniel Kral wrote:
> The reader_stderr parameter was introduced for a specific use case for
> the users of fork_ssh_tunnel(). The other callers, such as
> fork_websocket_tunnel(), do not provide the parameter and the Perl
> interpreter will warn about this:
> 
>     Use of uninitialized value $reader_stderr in <HANDLE> at /usr/share/perl5/PVE/Tunnel.pm line 77.
>     readline() on unopened filehandle at /usr/share/perl5/PVE/Tunnel.pm line 77.
> 
> [...]

Applied, thanks!

[1/1] tunnel: treat reader_stderr as optional parameter in read_tunnel
      commit: e10fabc1f26d73767aa984adb329a5a67b6ea57e