From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5A1FA1FF14F for ; Wed, 17 Jun 2026 14:12:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8041D32BC0; Wed, 17 Jun 2026 14:12:22 +0200 (CEST) Date: Wed, 17 Jun 2026 14:12:14 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH manager] ui: qemu: add detect zeroes disk option To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260608083614.35448-1-l.sichert@proxmox.com> <1781613942.xdqc7it20k.astroid@yuna.none> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1781698311.k5qeaocllq.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781698281022 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: NOQ7TI33T2R4OZ3B37JFRPHCEQZWG33H X-Message-ID-Hash: NOQ7TI33T2R4OZ3B37JFRPHCEQZWG33H X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On June 16, 2026 3:16 pm, Lukas Sichert wrote: > On 2026-06-16 15:01, Fabian Gr=C3=BCnbichler = wrote: >=20 >> if I am not mistaken, this is a fix for >> https://bugzilla.proxmox.com/show_bug.cgi?id=3D4503 ? >=20 > Yes, I have also corrected this in a v2 already [1], but I forgot to send= a > superseded-by. Sorry for the confusion. >=20 > [1] https://lore.proxmox.com/all/20260610131827.11092-1-l.sichert@proxmox= .com/ sorry, missed that (and so did b4 it seems)! >> On June 8, 2026 10:36 am, Lukas Sichert wrote: >>> When discard is enabled, qemu-server defaults to `detect-zeroes=3Dunmap= `. >>> This can have a significant performance impact for zero writes on some >>> setups, while users might still want to keep guest discard/TRIM support >>> enabled. >>>=20 >>> Allow configuring the option independently so discard can stay enabled >>> while zero detection is disabled. Persist the checkbox state explicitly= , >>> as the backend treats an absent value as the default-enabled behavior. >>>=20 >>> Signed-off-by: Lukas Sichert >>> --- >>> www/manager6/qemu/HDEdit.js | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>>=20 >>> diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js >>> index 1bb2bfda..d1d1b0fa 100644 >>> --- a/www/manager6/qemu/HDEdit.js >>> +++ b/www/manager6/qemu/HDEdit.js >>> @@ -96,6 +96,7 @@ Ext.define('PVE.qemu.HDInputPanel', { >>> PVE.Utils.propertyStringSet(me.drive, values.readOnly, 'ro', '= on'); >>> PVE.Utils.propertyStringSet(me.drive, values.cache, 'cache'); >>> PVE.Utils.propertyStringSet(me.drive, values.aio, 'aio'); >>> + me.drive.detect_zeroes =3D values.detect_zeroes ? 1 : 0; >> >> this should probably have a comment why this line is deviating from the >> ones above (to not lose an explicit false value that clashes with the >> implicit true default value of the backend. >=20 > Thanks for looking over this. I will fix it in a v3. ack.