From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server] migrate: Add more context to error message
Date: Tue, 16 Jun 2026 14:39:25 +0200 [thread overview]
Message-ID: <1781613401.yj8pmofmdm.astroid@yuna.none> (raw)
In-Reply-To: <20260603143434.494705-1-m.sandoval@proxmox.com>
On June 3, 2026 4:34 pm, Maximiliano Sandoval wrote:
> For context, when the target node has a qemu-server version older than
> 9.0.20, the "nets-host-mtu" option will be unknown to it and migrating a
> VM having the option set will fail.
>
> This error message might appear, for example, in a task log and without
> any indication of where it was emitted from, which can make debugging
> harder.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Just a small improvement to and error message that came up in a support ticket.
>
> src/PVE/QemuMigrate.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm
> index d4de9f87..ff7b3a39 100644
> --- a/src/PVE/QemuMigrate.pm
> +++ b/src/PVE/QemuMigrate.pm
> @@ -1125,7 +1125,7 @@ sub phase2_start_local_cluster {
> noerr => 1,
> );
>
> - die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade\n"
> + die "target node $self->{node} is too old for preserving VirtIO-net MTU, please upgrade qemu-server\n"
> if $target_nets_host_mtu_not_supported;
the changed message reads like a suggestion to upgrade *only*
qemu-server, which can be dangerous if dependency edges are missing by
accident..
>
> die "remote command failed with exit code $exitcode\n" if $exitcode;
> --
> 2.47.3
>
>
>
>
>
>
prev parent reply other threads:[~2026-06-16 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 14:34 [PATCH qemu-server] migrate: Add more context to error message Maximiliano Sandoval
2026-06-16 12:39 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1781613401.yj8pmofmdm.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.