From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BB63B1FF141 for ; Tue, 16 Jun 2026 14:36:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC8B08050; Tue, 16 Jun 2026 14:36:27 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com, Fiona Ebner Subject: Re: [PATCH-SERIES qemu-server 0/2] partially fix #7554: avoid incorrectly offline migrating qcow2 on LVM as raw Date: Tue, 16 Jun 2026 14:35:50 +0200 Message-ID: <178161334539.1984719.16245702707423859259.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260601145528.285536-1-f.ebner@proxmox.com> References: <20260601145528.285536-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781613297883 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QPW3LDE4426XDIZQ6Z5SHSZBXYCXI5RL X-Message-ID-Hash: QPW3LDE4426XDIZQ6Z5SHSZBXYCXI5RL X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 01 Jun 2026 16:55:00 +0200, Fiona Ebner wrote: > Because volumes were not activated early for offline migration, > getting the size and as a consequence the format would not work for > qcow2 on LVM. But migration also continued and not having the format > would lead to the 'with-snapshots' parameter not being set, despite > the format being qcow2 and so the migration would wrongly continue > with raw+size as the stream format. If 'with-snapshots' were set, the > plugin would correctly report that there is no possible transfer > format (the same restriction is present in file-based storages with > snapshot-as-volume-chain). > > [...] Applied, thanks! [1/2] migration: local volume: abort early when size or format cannot be determined commit: fafc9e4002ecbb0b7afa6380f7070c438c708370 [2/2] migration: local volume: activate for querying the size (required for qcow2 on LVM) commit: a82047357aa92f5bad6b3847e5047defa65d1a0e Best regards, -- Fabian Grünbichler