From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pmg-devel@lists.proxmox.com, Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: applied: [PATCH pmg-api] config: smtp-welcomelist: avoid short-circuiting due to side-effects
Date: Wed, 10 Jun 2026 11:57:40 +0200 [thread overview]
Message-ID: <178108545876.3842880.16149101362296571032.b4-ty@b4> (raw)
In-Reply-To: <20260610091356.958395-1-s.ivanov@proxmox.com>
On Wed, 10 Jun 2026 11:13:53 +0200, Stoiko Ivanov wrote:
> the version with the post-if also reads a bit nicer to me.
>
> a similar issue was fixed in 2022:
> 991d8f1c ("pmg-daily: avoid short-circuting update of local channels")
>
> minimally tested by:
> * removing all smtp-welcomelist files in /etc/postfix and their
> postmap .db result (senderaccess rcptaccess clientaccess
> postscreen_access)
> * manually modifying /etc/postfix/master.cf (adding a -v to smtpd)
> * adding an entry to the Mail Proxy Welcomelist in the GUI
> * checking that all files were created and that postfix was reloaded
>
> [...]
Applied, thanks!
[1/1] config: smtp-welcomelist: avoid short-circuiting due to side-effects
commit: 02f0186c63e984e2b423f21fec3419eba35efebd
prev parent reply other threads:[~2026-06-10 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 9:13 [PATCH pmg-api] config: smtp-welcomelist: avoid short-circuiting due to side-effects Stoiko Ivanov
2026-06-10 9:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178108545876.3842880.16149101362296571032.b4-ty@b4 \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.