From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id ED3DF1FF13B for ; Wed, 03 Jun 2026 14:56:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F5E7B832; Wed, 3 Jun 2026 14:56:08 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pdm-devel@lists.proxmox.com, Shannon Sterz Subject: applied-series: [PATCH datacenter-manager v2 0/2] fix an issue with cached subscription info Date: Wed, 3 Jun 2026 14:55:47 +0200 Message-ID: <178049133802.980014.6173932895583606706.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260603122735.425390-1-s.sterz@proxmox.com> References: <20260603122735.425390-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780491327964 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F3MH7OVSOF2IWKAQKYIUJRQQG5HNKKD6 X-Message-ID-Hash: F3MH7OVSOF2IWKAQKYIUJRQQG5HNKKD6 X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 03 Jun 2026 14:27:31 +0200, Shannon Sterz wrote: > and slightly improve the caching mechanism. the second patch here is > optional, it's just something i noticed while debugging. > > Changelog > --------- > > changes since v1 (thanks @ Fabian Grünbichler): > - https://lore.proxmox.com/pdm-devel/20260603115442.361184-1-s.sterz@proxmox.com/) > * added a helper function that guarantees freshly fetched info that > never touched the cache. the last version had a slight chance of a > race occurring and us again getting cached, incomplete information. > * improved logging. > > [...] Applied, thanks! [1/2] server: subscription: always get fresh subscription info on update commit: 72d513fd6e700cc8fb9bc97d427e5d8a6b7934e3 [2/2] server: cache: short-circuit on special max age value 0 commit: 108de23bd062838c50e4b9d52cb0ad936c2a6bf3 Best regards, -- Fabian Grünbichler