From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 60EE01FF13C for ; Thu, 28 May 2026 13:18:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02E8E140BB; Thu, 28 May 2026 13:18:26 +0200 (CEST) From: Thomas Lamprecht To: yew-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH yew-comp] wizard: fix page unlocking with advanced fields Date: Thu, 28 May 2026 13:17:39 +0200 Message-ID: <177996705426.1976860.16471421617388084019.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260528091851.1424576-1-d.csapak@proxmox.com> References: <20260528091851.1424576-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779967045122 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 46ERKIW6YCZLUN6GZS4K5DZ3NZI2UD6D X-Message-ID-Hash: 46ERKIW6YCZLUN6GZS4K5DZ3NZI2UD6D X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Yew framework devel list at Proxmox List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 28 May 2026 11:18:45 +0200, Dominik Csapak wrote: > The wizard depends on the form context validation of the pages to > determine which to lock and unlock. Initially all pages are locked and > only if the form_ctx changes and is valid the corresponding page will be > unlocked. With the introduction of the advanced button in the wizard, > this can happen for pages even if they're not rendered yet. > > For pages that are by default invalid (e.g. includes a required field > that is empty at the start) this means the form_ctx will show is_valid > since none of the form fields are registered yet with it. > > [...] Applied, thanks! [1/1] wizard: fix page unlocking with advanced fields commit: 5f057210b197042c1223e39e3dee3f802754234c