From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9329B1FF146 for ; Tue, 26 May 2026 16:30:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC19A345E; Tue, 26 May 2026 16:30:11 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Dominik Csapak Subject: Re: [PATCH datacenter-manager] ui: auto-installer: correctly validate numeric counters in form Date: Tue, 26 May 2026 16:29:31 +0200 Message-ID: <177980576888.2294399.13952278892704952663.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260526140647.3594593-1-d.csapak@proxmox.com> References: <20260526140647.3594593-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779805753582 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NSWYUXB2CUPNSMJQ3PL6REZSX2CVRFPX X-Message-ID-Hash: NSWYUXB2CUPNSMJQ3PL6REZSX2CVRFPX X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 May 2026 16:06:42 +0200, Dominik Csapak wrote: > field values are usually strings, so when a user entered any number > here, it would display: > > invalid value: "1" > > since only numbers were expected here. > > [...] Applied, thanks! [1/1] ui: auto-installer: correctly validate numeric counters in form commit: 060fcee43159768d83521b66b1bb120eb4e52219