From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BEC211FF146 for ; Tue, 26 May 2026 16:18:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A291A2883; Tue, 26 May 2026 16:18:31 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH datacenter-manager] ui: auto-installer: improve auto-installer command line template Date: Tue, 26 May 2026 16:17:51 +0200 Message-ID: <177980504066.2276930.238054849484805170.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260526132248.531503-1-c.ebner@proxmox.com> References: <20260526132248.531503-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779805052740 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: T2EQIGB5XTAWTVGUIJGSIUKTSFFSHRQM X-Message-ID-Hash: T2EQIGB5XTAWTVGUIJGSIUKTSFFSHRQM X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 26 May 2026 15:22:48 +0200, Christian Ebner wrote: > The auto-generated command line for the auto-installer to be copied > by an user needs to be adapted to include the source image. An > unexpecting user might just copy the command and past it, running > into a not so telling: `Error: free-standing argument is missing`. > > Make it clearer that this is a template only and add a template input > file, which leads to the following more telling error messages on > missing or unrelated input files: > - `Error: Source file "SOURCE-INPUT-FILE" does not exist.` > - `Error: The source ISO file is not able to be installed automatically. > Please try a more current one.` > > [...] Applied, thanks! I renamed the placeholder to INPUT.iso (the .iso hints the file type) and reword tip to "Replace ..." since "adapt" reads like modifying the file itself. [1/1] ui: auto-installer: improve auto-installer command line template commit: e41051695cab1dfeb31c46e0db700e9f58254170