From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7A71E1FF145 for ; Sun, 24 May 2026 04:32:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 084991E167; Sun, 24 May 2026 04:32:35 +0200 (CEST) From: Thomas Lamprecht To: pdm-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH datacenter-manager/proxmox-geojson-data/yew-widget-toolkit/yew-widget-toolkit-assets v3 00/11] add a new map widget for custom views Date: Sun, 24 May 2026 04:31:53 +0200 Message-ID: <177958850380.3496597.6055465071297315320.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260522083412.1223719-1-d.csapak@proxmox.com> References: <20260522083412.1223719-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779589899826 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.120 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KKZ3YO5BY6ROU2L2GFVOUMUONPEET7WQ X-Message-ID-Hash: KKZ3YO5BY6ROU2L2GFVOUMUONPEET7WQ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 22 May 2026 10:33:56 +0200, Dominik Csapak wrote: > This series let's users add location info to remotes (longitude,latitude) and > makes it possible to show them on a map in a custom view. > > This map is interactive, so it let's you zoom/pan/etc. (with touch controls too) > > It also adds new status info per remote to the resources status api call > so we can show some sensible info on the map (success/warn/error). > > [...] Applied, thanks! I made a few changes on top while applying: - yew-widget-toolkit: keep the map info card stable during interaction and fix its dismissal and cursor reset, re-cluster after a pinch zoom while skipping no-op zooms, guard the client-to-SVG coordinate helper against a missing CTM, namespace the location CSS custom properties, and give the segmented button a group role and aria-label. - yew-widget-toolkit-assets: namespace the Map location custom properties to match the toolkit change. - datacenter-manager: keep cached locations for unreachable remotes and tolerate unreachable PVE nodes, cap the map info card height, follow the renamed location color property, switch the server over to the now typed pve-api-types cluster options and location, and add end-user documentation for the available custom-view widgets and the new map widget. Related, outside this series: I factored out dedicated node location types and a typed cluster options return in pve-api-types, backed by a new pve-node-location property-string format in pve-common that pve-cluster and pve-manager reference, which is what the datacenter-manager server now consumes. Some feedback for a possible follow-up, nothing blocking as this is already applied: - The rendered map looks noticeably coarser than the 1:110m source material it is generated from, so it would be good to double-check that we are not losing detail somewhere along the way (fine if zoomed out, but might be nice to add full details when zooming closer). - One or two more zoom levels would be great for the user experience: with several remotes located in the same city the current maximum zoom cannot really tell them apart. [proxmox-yew-widget-toolkit]: [1/3] js-helper: add client-to-svg-coordinate conversion helper commit: 835cd497f9fbd4dfa1831e3b5f1ce98b9ebdf913 [2/3] widget: charts: add interactive Map with zoom/pan and clustering commit: 742ffe78d874f028c5ed68dbaaf18b9d9ca84b64 [3/3] widget: charts: add WorldMap with GeoJSON rendering commit: 7f360d03129480f38adb87ee946c4209f39f38ee [proxmox-datacenter-manager]: [1/6] server: pbs client: add node_config method commit: 17df8309266332245386f3a6de70b3733897d227 [2/6] lib/api: add 'location-info' api call with cached information commit: 9a8ef4bfe73e6cc9fa6712aae69f3a1ff9d90a67 [3/6] lib/api: add new 'remote-list' info to the resource status commit: b20879665fbdcbc9765f2451bea4db8434a09317 [4/6] server: serve geojson worldmap commit: 39b36565cee582f2aace228603c9128b0f8e7ba9 [5/6] ui: views: refactor required api call info into struct commit: 2da1b4833b4d99efea5e616da56bc918179b2056 [6/6] ui: views: add map component commit: 6173037e8faf0ce5236bf2b01f54136979f5cdfe [proxmox-geojson-data]: [1/1] initial commit commit: be241be54abf5928876f3777c7d6967e74d2f7c9 [yew-widget-toolkit-assets]: [1/1] charts: add necessary classes for Map commit: cff62b10facac4778a688491b95653b91a18b7f2