From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pdm-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id D6D551FF141
	for <inbox@lore.proxmox.com>; Tue, 19 May 2026 17:10:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2C2A4C37A;
	Tue, 19 May 2026 17:10:58 +0200 (CEST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH datacenter-manager v3 05/12] ui: registry: add view
 with key pool and node status
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20260515074623.766766-6-t.lamprecht@proxmox.com>
References: <20260515074623.766766-1-t.lamprecht@proxmox.com>
 <20260515074623.766766-6-t.lamprecht@proxmox.com>
Date: Tue, 19 May 2026 17:08:58 +0200
Message-Id: <177920333892.90544.12661132965173640598.b4-review@b4>
X-Mailer: b4 0.15.2
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1779203411385
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.087 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: ED56W4X6IS4XFNO7XLHXKLMOGU6X7UHS
X-Message-ID-Hash: ED56W4X6IS4XFNO7XLHXKLMOGU6X7UHS
X-MailFrom: w.bumiller@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pdm-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Datacenter Manager development discussion
 <pdm-devel.lists.proxmox.com>
List-Help: <mailto:pdm-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pdm-devel-owner@lists.proxmox.com>
List-Post: <mailto:pdm-devel@lists.proxmox.com>
List-Subscribe: <mailto:pdm-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pdm-devel-leave@lists.proxmox.com>

On Fri, 15 May 2026 09:43:15 +0200, Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> diff --git a/ui/src/configuration/subscription_registry.rs b/ui/src/configuration/subscription_registry.rs
> new file mode 100644
> index 0000000..513fa3a
> --- /dev/null
> +++ b/ui/src/configuration/subscription_registry.rs
> @@ -0,0 +1,1019 @@
> [ ... skip 151 lines ... ]
> +
> +    let mut tree = SlabTree::new();
> +    let mut root = tree.set_root(NodeTreeEntry::Root);
> +    root.set_expanded(true);
> +
> +    for (remote_name, remote_nodes) in &by_remote {

↑ could drop the `&` here and avoid the `n.clone()` below…

> [ ... skip 18 lines ... ]
> +                total,
> +            });
> +            remote_entry.set_expanded(true);
> +            for n in remote_nodes {
> +                remote_entry.append(NodeTreeEntry::Node {
> +                    data: n.clone(),

… here ↑

--