From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 401461FF135 for ; Sun, 17 May 2026 02:02:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B28633CB9; Sun, 17 May 2026 02:02:44 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Gabriel Goller Subject: Re: [PATCH frr v2 0/3] Backport FRR EVPN local RT2 leaking fixes Date: Sun, 17 May 2026 01:59:45 +0200 Message-ID: <177897588457.770468.8377906826309521859.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515120351.395649-1-g.goller@proxmox.com> References: <20260515120351.395649-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778976115803 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KXEGNNWW2QJ4QD7LB74UANATLDB6WON5 X-Message-ID-Hash: KXEGNNWW2QJ4QD7LB74UANATLDB6WON5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 15 May 2026 14:03:44 +0200, Gabriel Goller wrote: > Since packaging 10.6.1, we also pull in the EVPN local RT2 leaking patches > (which are applied on upstream master). > > The RT2 route leaking PR seems to have some race-condition-related problems, > namely a crash at bgp router shutdown and one case in which the rt2 route is not > leaked (see the last comment at #20005 [1]). > > [...] Tested thise one with 500 VXLAN+bridge churn cycles on a host with the EVPN address-family active (no leaks, no asserts, +12 KB bgpd RSS) and a `no router bgp` with an active VNI to exercise the new cleanup path (runs clean). The 21 commits across both upstream PRs (#21511 and #21844) were also checked against upstream and are logically equivalent; deviations are limited to a few hunks that account for backport-target context that doesn't exist in 10.6.1 yet, so: Applied, thanks! btw. I resolved the merge conflict with the other series, but it isn't perfect git history wise - but we probably won't have to bisect these two commits on the packaging level, or rather, one can relatively easy work around doing so. [1/3] frr: backport "bgpd: fix valgrind memory leaks on daemon shutdown" (#21511) commit: 6ddac172c96f3bad0f90f5d61876e98344c33c0c [2/3] frr: backport the "Memory leak problems." (#21844) upstream PR commit: 4e14853e8f9d59d47b5f35792ce6efe601601d5f [3/3] bump to version 10.6.1-1+pve2 commit: 9f188e1b4459edfd6174aa1ad48ee4ab6bde7749