From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3ADBE1FF13A for ; Wed, 13 May 2026 04:08:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 150F4316C8; Wed, 13 May 2026 04:08:41 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com, Lukas Wagner Subject: applied: [PATCH common/proxmox{,-backup}/storage v2 0/9] establish unique instance-id for PBS nodes Date: Wed, 13 May 2026 04:05:25 +0200 Message-ID: <177863755633.3889845.18092870907983412159.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260424082943.89614-1-l.wagner@proxmox.com> References: <20260424082943.89614-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778637973009 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.147 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: REJGA4KBMHKECZXTOJTAGYFE3EUWD5GK X-Message-ID-Hash: REJGA4KBMHKECZXTOJTAGYFE3EUWD5GK X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 24 Apr 2026 10:29:34 +0200, Lukas Wagner wrote: > In PDM we require some way to match PBS storage <-> PBS remote. > > Having some kind of unique ID for each PBS instance should make it quite easy > to establish such a mapping completely automatically. > > The general approach is > 1.) add /nodes/localhost/server-identity route in PBS, returning a unique, per-installation ID > 2.) add something like /nodes/.../storage//identity in PVE, which uses > proxmox-backup-client internally to return the instance ID for this PBS storage > 3.) PDM can then use both API routes to establish the mapping > > [...] Applied now the remaining storage patches, thanks! Fix-ups inline: - APIVER bump: kept APIAGE bumped (no reset). get_identity is opt-in via the new route, so resetting would re-version every external plugin for no benefit. Also added an ApiChangeLog v14 entry so external plugin authors can more quickly see what changed. - /identity: fixed broken string concat in the 'id' property description. Follow-ups on top: - /identity: also accept Datastore.AllocateSpace (any => 1), matching the surrounding per-storage read endpoints. - /identity: add storage_check_enabled check, like basically all others and as it seems sensible to not query those. [1/3] plugin: add get_identity method commit: cb45db06786704cfe5d5962372bf5d9f31f51e53 [2/3] bump storage plugin APIVER and APIAGE commit: 336e508b50e0145a5c6b9b5ee3b7886fd010dc94 [3/3] api: add /nodes//storage//identity route commit: f4f617adb8dedd2a02375d3b44b98e28611f71f4