From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2DB5A1FF13A for ; Wed, 13 May 2026 02:34:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6BD130FA0; Wed, 13 May 2026 02:34:46 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, David Riley Subject: applied: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid Date: Wed, 13 May 2026 02:33:50 +0200 Message-ID: <177863242554.3618550.18412291321944223153.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327103801.104735-1-d.riley@proxmox.com> References: <20260327103801.104735-1-d.riley@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778632369071 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JQTWWLS3X5AMRWU6XZ7MIBGCBNCWCSAT X-Message-ID-Hash: JQTWWLS3X5AMRWU6XZ7MIBGCBNCWCSAT X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Mar 2026 11:38:00 +0100, David Riley wrote: > This v2 implements the suggested stop-gap solution for filtering the > virtual guest selection in the backup job edit window. > > Differences from v1: > - Drop the complex collapsible filter panel (tags, pools, HA State) > This avoids the UX trap of users thinking the filters apply > dynamically at job runtime (deferring that feature for a proper > implementation of #4186 [0]). > - Add search text-field in the grid toolbar to filter by > Name or VMID. > - Add a "Review" toggle checkbox in the bottom toolbar that limits > the grid view to only currently selected guests. > - Add a "Selected (X)" counter in the bottom toolbar for immediate > visual feedback. > - Override the `getValue` collection logic to gather data directly > from the SelectionModel, ensuring virtual guests hidden by the > Search filter are still correctly submitted. > > [...] Applied, thanks! FYI: I factored the now ~three time existing search widget out into a common module in a follow-up and did some minor adaptions. [1/1] fix: #4490 ui: backup job window: add search for virtual guest grid commit: 7ad74616a0b7bd5f8999a28f429963980298f9e9